[designspace/ufo] Add tests for RTL kerning edge case#2417
Merged
justvanrossum merged 5 commits intomainfrom Feb 13, 2026
Merged
[designspace/ufo] Add tests for RTL kerning edge case#2417justvanrossum merged 5 commits intomainfrom
justvanrossum merged 5 commits intomainfrom
Conversation
… classify as rtl via GSUB closure
… classify as rtl via GSUB closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an unencoded RTL glyph that can only be classified as such via GSUB closure, and add a kerning pair with this glyph and
period(which has a neutral direction). This verifies the RTL shuffle logic also works correctly in this case.Additionally: purge the glyph direction classification cache when the features change.