[designspace] Fix fast successive put/delete glyph and false positives in reload-on-external-change#2374
Merged
justvanrossum merged 6 commits intomainfrom Jan 13, 2026
Merged
Conversation
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The context is: deleting ar pasting a bunch of glyphs in the font overview, and then doing Undo before the write to the backend has completed. This is quite possible with complex designspaces (when a single glyph is stored as many .glif files), since writing glyphs is quite slow (in this backend), although the user generatty doesn't notice as it happens in the background. This caused a variety of problems due to a design flaw and a bug. This PR fixes both.
putGlyphcall to be skipped it it is succeeded by adeleteGlyph. This would cause a KeyError if the glyph didn't exist in the first place. Change the behavior ofdeleteGlyph()so it doesn't raise KeyError when passed an unknown glyph.