Skip to content

GTK-based "Bitmap Strikes" dialog#5708

Merged
iorsh merged 52 commits intofontforge:masterfrom
iorsh:bitmaps_dlg
Feb 28, 2026
Merged

GTK-based "Bitmap Strikes" dialog#5708
iorsh merged 52 commits intofontforge:masterfrom
iorsh:bitmaps_dlg

Conversation

@iorsh
Copy link
Copy Markdown
Contributor

@iorsh iorsh commented Dec 19, 2025

This PR replaces legacy "Find Problems" dialog with a GTK-based one. Fixes #3346.

Changes:
New UI:
bs_proj

Old UI:
bs_sys

  • List of numbers is locale-sensitive, uses semicolon as list separator when the comma is used as decimal point.
  • OS-based monitor resolutions are gone, showing the typical 96 PPI resolution, and the user's actual resolution.
  • Point sizes are read-only now, the bitmap strikes should be defined by pixel height only.
  • "Use FreeType" option is gone. FreeType is always available, and the rasterization uses it.
  • Error indication is now inline:
bs_proj_err

iorsh added 30 commits November 27, 2025 00:26
@iorsh
Dummy Bitmaps dialog
ea23966
@iorsh
Create Bitmaps dialog
584de77
@iorsh
ff::utils namespace
c27e292
@iorsh
Add ui_utils::get_current_ppi()
e687fcd
@iorsh
Use get_current_ppi() in BitmapsDlg
63122e0
@iorsh
Remove deprecated register keyword
d15ec9f
@iorsh
Use Unicode bullets for label list
6f22719
@iorsh
Fix PPI retrieval
0acb2e6
@iorsh
Disable Gtk::ComboBoxText item, fine-tune dialog
71a98b7
@iorsh
Extract BitmapsDlg::build_glyphs_combo()
4a052fb
@iorsh
Propagate and show bitmap sizes
fbef1fa
@iorsh
Add numeric local utils
f0cdae1
@iorsh
Show point sizes for selected monitor resoltions
4de4ded
@iorsh
Adapt ParseList() from old C code
df02b7f
@iorsh
Fix ui_font_eX_size()
c925688
@iorsh
Add VerifiedEntry widget
65f82f4
@iorsh
Fix legacy CSS priority
49e874b
@iorsh
Verify pixel size entry
8f0f33b
@iorsh
Calculate px to pt sizes
c7bfc8d
@iorsh
Disable "Selected Glyphs" when unapplicable
b6a2945
@iorsh
VerifiedEntry comment
ed0766d
@iorsh
Finalize inputs and outputs
14084ac
@iorsh
Apply result of GTK dialog
f1b0159
@iorsh
Name existing enum bd_scope
4cc3440
@iorsh
Remove legacy Bitmap strikes dialog
8e88a6f
@iorsh
Always use FreeType
d19ea96
@iorsh
Remove "DefaultScreenDpiSystem" preference
e0223ff
@iorsh
Remove bdfcontrol_lastwhich and remember last scope in dialog
5f58040
@iorsh
Clean #includes
401875e
@iorsh
Rename C++ keyword clashes
7285f15
@iorsh iorsh requested a review from skef February 27, 2026 22:37
skef
skef approved these changes Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread fontforgeexe/gtk/bitmaps_dlg.cpp Outdated
@iorsh iorsh merged commit c977671 into fontforge:master Feb 28, 2026
8 checks passed
@iorsh iorsh deleted the bitmaps_dlg branch February 28, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skef skef skef approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conflicting interpretation of comma with some locales (ex. French locale)

2 participants

@iorsh @skef