Skip to content

GTK-based "Find Problems" dialog#5682

Merged
iorsh merged 50 commits intofontforge:masterfrom
iorsh:find_problems_dlg
Feb 27, 2026
Merged

GTK-based "Find Problems" dialog#5682
iorsh merged 50 commits intofontforge:masterfrom
iorsh:find_problems_dlg

Conversation

@iorsh
Copy link
Copy Markdown
Contributor

@iorsh iorsh commented Nov 14, 2025

This PR replaces legacy "Find Problems" dialog with a GTK-based one. The fix improves dialog layout and arbitrary line breaks in long messages, which can't be properly localized.

Fixes #3899, fixes #3031.

New UI:
findprobs

Old UI:
prob_dflt_sys

@iorsh iorsh changed the title Find problems dlg GTK-based "Find Problems" dialog Nov 14, 2025
@iorsh iorsh force-pushed the find_problems_dlg branch from 0c72552 to c6c2cf5 Compare November 25, 2025 20:55
@iorsh iorsh force-pushed the find_problems_dlg branch from 49cb7ac to 154b984 Compare January 16, 2026 20:45
@skef
Copy link
Copy Markdown
Contributor

skef commented Jan 16, 2026

Since this has some movement, what does the new window do when it needs to wrap its tabs (e.g. if localization makes those names longer)?

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Jan 16, 2026

Since this has some movement, what does the new window do when it needs to wrap its tabs (e.g. if localization makes those names longer)?

Fixed, the tabs should look like this now (note the arrows):
image

I'd be grateful if you could review the entire PR, Frank is quite busy recently.

@skef
Copy link
Copy Markdown
Contributor

skef commented Jan 16, 2026

It's a lot but I'll try to take a look.

@skef
Copy link
Copy Markdown
Contributor

skef commented Jan 16, 2026

Independent of the review, it might be good if you could sort of fuzz for analogous formatting problems. That question was based on a pure guess on my part; there could be other things.

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Jan 16, 2026

Actually, it was a direct hit. I did consider the other stuff, but couldn't see any way to wrap tab labels, so I just left them concise. Found the solution now by re-reading the documentation for Gtk::Notebook

There are also item labels which I intentionally unabbreviated, none of them seems to span more than a monitor width (even with very generous margins). Tooltips can be very long, but I removed all newlines from them, and GTK wraps them automatically:
image

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Jan 16, 2026

Btw, this one is big indeed, but you can pick any of my recent PRs (the latest six are all unreviewed) if you have some time for that. Thanks!

@iorsh iorsh force-pushed the find_problems_dlg branch from 47b6622 to e9629f7 Compare January 16, 2026 21:50
@skef
Copy link
Copy Markdown
Contributor

skef commented Feb 14, 2026

Been looking at this a bit more. I added a branch called "modules-5682, which is:

  1. The modules branch
  2. With this branch ported on top
  3. and problems.c renamed to problems.cpp and ported to minimal c++

Once the modules code is committed, this will make it easier for you to factor out a bunch of the C->C++->C bridging code, which I think would be an overall win.

@iorsh iorsh force-pushed the find_problems_dlg branch from 1c07868 to 9f50176 Compare February 25, 2026 22:02
@iorsh iorsh requested a review from skef February 25, 2026 22:03
Comment thread fontforgeexe/gtk/find_problems.cpp Outdated
Comment thread fontforgeexe/gtk/widgets/num_entry.hpp Outdated
Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skef
Copy link
Copy Markdown
Contributor

skef commented Feb 27, 2026

I don't know if there's any MID stuff in here, but why don't you merge this first and I'll figure out in #5763 after.

@iorsh iorsh merged commit 200a1d5 into fontforge:master Feb 27, 2026
8 checks passed
@iorsh iorsh deleted the find_problems_dlg branch February 28, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialog window width and height Find problems dialogue and message size to be improved

2 participants