Skip to content

Fix a crash caused by deleting a glyph with vertical kerning pairs.#5592

Merged
iorsh merged 1 commit intofontforge:masterfrom
BradEdwards:master
Jul 30, 2025
Merged

Fix a crash caused by deleting a glyph with vertical kerning pairs.#5592
iorsh merged 1 commit intofontforge:masterfrom
BradEdwards:master

Conversation

@BradEdwards
Copy link
Copy Markdown
Contributor

  • SFRemoveGlyph removed the horizontal kerning pairs but left vertical kerning pairs pointing to the deleted glyph.
  • This could cause crashes when then accessing the vkerns.

Type of change

- SFRemoveGlyph removed the horizontal kerning pairs but left vertical kerning pairs pointing to the deleted glyph.
- This could cause crashes when then accessing the vkerns.
Copy link
Copy Markdown
Contributor

@iorsh iorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@iorsh iorsh merged commit 664b5db into fontforge:master Jul 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting a glyph with vertical kerning pairs leaves those vkerns pointing to the deleted glyph

2 participants