Add minimal support for GDEF version 1.3#5584
Merged
iorsh merged 1 commit intofontforge:masterfrom Jul 20, 2025
Merged
Conversation
Instead of checking the full version number and rejecting any new versions, check for major version number since new minor versions add new fields but do not change existing ones. This allows loading glyph classes etc from GDEF version 1.3, while ignoring item variation sore as OpenType variations in general are not supported by FontForge Also report when unsupported table version is seen, instead of silently ignoring it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking the full version number and rejecting any new versions, check for major version number since new minor versions add new fields but do not change existing ones.
This allows loading glyph classes etc from GDEF version 1.3, while ignoring item variation sore as OpenType variations in general are not supported by FontForge
Type of change