Skip to content

Fix scaling of references in CharView#5558

Merged
iorsh merged 1 commit intofontforge:masterfrom
iorsh:resize_ref
Jun 19, 2025
Merged

Fix scaling of references in CharView#5558
iorsh merged 1 commit intofontforge:masterfrom
iorsh:resize_ref

Conversation

@iorsh
Copy link
Copy Markdown
Contributor

@iorsh iorsh commented May 8, 2025

Preserve reflayer::splines for Undo operation

Type of change

Note: it's not clear why RefChar holds a copy of layers in struct reflayer. It looks like an unnecessary and buggy data duplication. It could be good to remove it altogether, but at the moment such a refactoring would probably be too big and risky.

Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemzwerg
Copy link
Copy Markdown
Member

Sorry for the late reply. It works for me, thanks!

@iorsh iorsh merged commit 9dad24b into fontforge:master Jun 19, 2025
7 checks passed
@iorsh iorsh deleted the resize_ref branch June 26, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scaling composite glyph vertically fails

3 participants