Simple GTK-based dialog with CSS appearance support#5546
Merged
iorsh merged 49 commits intofontforge:masterfrom Jun 29, 2025
Merged
Simple GTK-based dialog with CSS appearance support#5546iorsh merged 49 commits intofontforge:masterfrom
iorsh merged 49 commits intofontforge:masterfrom
Conversation
… C17, C++20 for now
Contributor
Author
|
Currently the GTK window doesn't block its parent legacy window from receiving mouse events, and this can lead to crashes or issues. We plan to fix it later, once we have initial feedback of GTK usability and stability. |
frank-trampe
approved these changes
Jun 26, 2025
Contributor
frank-trampe
left a comment
There was a problem hiding this comment.
We talked through this, and it makes sense. It is impossible to test all cases on all platforms. We will fix anything that breaks in testing at a later time. It is a small change, so any problems ought to be minimally disruptive.
iorsh
commented
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for GTK3 / GTKMM3-based UI. Only "Add Encolding Slots" dialog was ported, to keep stability while allowing for initial testing. Based on infrastructure work by @Omnikron13.
The customized UI appearance is supported with CSS - see screenshots.
Tested on Linux (KDE, Gnome under X, Wayland), Windows 64-bit, macOS. Binaries for testing are available at https://github.com/iorsh/fontforge/actions/runs/14070685506 (scroll to the end of the page).
Known issues:
See also discussion #5324.
New GTK-based UI (default FontForge apperance):
Legacy GDraw-based UI (default FontForge apperance):
New GTK-based UI (customized FontForge apperance):
Legacy GDraw-based UI (customized FontForge apperance):