Fix function PyFFFont_addSmallCaps.#5519
Merged
skef merged 1 commit intofontforge:masterfrom Jan 1, 2025
Merged
Conversation
(1) The initialization of struct genchange was incomplete.
Transfer values from native scripting function bSmallCaps.
(2) Components stem_width_scale and stem_height_scale
were not reliably initialized.
Contributor
Author
|
The documentation of Python method I'd suggest to document these parameters and point out that they |
Contributor
|
I'm fine with this. I have some vague suspicions, that the same initial values should also appear somewhere in UI, but this change by itself is sufficient. |
iorsh
approved these changes
Jan 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
(1) The initialization of
struct genchangewas incomplete.I transfered the values from native scripting function bSmallCaps
to fill the gaps.
(2) Components
stem_width_scaleandstem_height_scalewere not reliably initialized.