Use PyConfig API on Python 3.8 by vstinner · Pull Request #5404 · fontforge/fontforge

vstinner · 2024-04-18T11:01:36Z

The Py_SetProgramName() function used by fontforge is deprecated and was removed in Python 3.13 alpha 1.

Replace the deprecated function with the PyConfig API on Python 3.8. If the Python initialization fails, log an error to stderr and call exit(1).

Type of change

Bug fix
New feature
Breaking change
Non-breaking change

iorsh · 2024-08-03T22:44:25Z

PyConfig API was introduced in 3.8 (released in 2019), and we are currently requiring Python 3.6 (released in 2016).
Maybe we should just bump required Python3 version to 3.8?

For reference, Ubuntu 20 (the oldest supported LTS) uses 3.8.

vstinner · 2024-08-05T08:40:35Z

Maybe we should just bump required Python3 version to 3.8?

That's up to you. My PR remains backward compatible with Python 3.6.

myoresh · 2024-08-05T08:43:55Z

PyConfig API was introduced in 3.8 (released in 2019), and we are currently requiring Python 3.6 (released in 2016). Maybe we should just bump required Python3 version to 3.8?

For reference, Ubuntu 20 (the oldest supported LTS) uses 3.8.

@skef ?

skef · 2024-08-05T08:49:29Z

It's probably been long enough to bump to 3.8. (No guarantees that someone with more authority won't slap our wrists before it happens.)

iorsh · 2024-08-05T09:00:09Z

Ok, so let's bump. @vstinner, could you please update the PR?
@skef, do you want to CC specific people who might want to weigh in here?

vstinner · 2024-08-05T09:28:31Z

I rebased my PR to remove code for Python 3.7 and older: only keep PyConfig code for Python 3.8 and newer. I didn't test my change, I rely on the CI for that.

vstinner · 2024-08-05T09:28:55Z

"linux (ubuntu-20.04, Release) Expected — Waiting for status to be reported" is the CI working? I don't see a link to the CI job.

iorsh · 2024-08-05T09:35:52Z

Please update Python version in CMakeLists.txt
find_package_auto(ENABLE_PYTHON_SCRIPTING Python3 3.6 COMPONENTS Development Interpreter)

skef · 2024-08-05T09:45:22Z

do you want to CC specific people who might want to weigh in here?

Nah. If they wanna look they can look.

JoesCat · 2024-08-05T11:18:44Z

At some point you gotta break from maintaining for Horse carriages and buggy wips.

The Py_SetProgramName() function used by fontforge is deprecated and was removed in Python 3.13 alpha 1. Replace the deprecated function with the PyConfig API. If the Python initialization fails, log an error to stderr and call exit(1). CMakeLists.txt: change Python minimum version to 3.8.

vstinner · 2024-08-05T12:06:43Z

Please update Python version in CMakeLists.txt

Done.

vstinner · 2024-09-02T23:16:04Z

@iorsh: Would you mind to review the updated PR?

iorsh · 2024-09-03T05:16:41Z

@skef, could you please approve CI workflows?

iorsh · 2024-09-03T18:21:12Z

CI is broken, issue unrelated to this PR. I'll need to take a look.

iorsh · 2024-09-03T18:40:26Z

@JoesCat , could you please downgrade autoconf requirement in libspiro to 2.69 (see https://github.com/fontforge/libspiro/blob/da2d627d4147e75bada0f3923c262ada81cbec76/configure.ac#L6)?
Ubuntu 20.04 only has autoconf 2.69, and now its CI action is broken.

AC_PREREQ(2.70) downgraded to 2.69 for ELN distros, as explained here: fontforge/fontforge#5404 (comment)

JoesCat · 2024-09-03T21:13:34Z

Wheels of progress are quick. Updated to 1.5 now with change added for 2.69.

iorsh

Looks good to me now

vstinner · 2024-09-24T15:20:41Z

CI is broken, issue unrelated to this PR. I'll need to take a look.

The Linux CI fails with:

/home/runner/work/fontforge/fontforge/repo/.github/workflows/scripts/setup_linux_deps.sh: line 37: pushd: libuninameslist: No such file or directory
/home/runner/work/fontforge/fontforge/repo/.github/workflows/scripts/setup_linux_deps.sh: line 38: pushd: woff2: No such file or directory

iorsh · 2024-09-24T15:27:02Z

/home/runner/work/fontforge/fontforge/repo/.github/workflows/scripts/setup_linux_deps.sh: line 37: pushd: libuninameslist: No such file or directory
/home/runner/work/fontforge/fontforge/repo/.github/workflows/scripts/setup_linux_deps.sh: line 38: pushd: woff2: No such file or directory

That was libspiro, I think. Try to force push to trigger CI again, linux should be good now. Mac still broken though...

vstinner · 2024-09-25T05:38:35Z

The CIs were stuck. I close/reopen the PR to force new CI jobs.

vstinner · 2024-09-25T06:01:05Z

@iorsh:

Try to force push to trigger CI again, linux should be good now.

I pushed an empty commit and then closed/reopened the PR, but CIs don't want to start. They are stuck at "Expected — Waiting for status to be reported" with no "Details" link.

skef

LGTM

skef · 2024-10-07T08:48:19Z

@iorsh for whatever reason the mac job is hanging before getting picked up by a server. Could the OS version be wrong/unavailable?

vstinner · 2024-10-07T08:51:30Z

Oh, I forgot to call PyConfig_Clear(): it's now fixed.

iorsh · 2024-10-07T08:53:58Z

This and all other PRs are still based on macos-11 runner, which is dead. Now, as #5423 is merged, they all need to be merged/rebased to the latest master for CI to pass.

@vstinner, could you please merge/rebase?

skef · 2024-10-07T08:58:33Z

It's working now.

vstinner · 2024-10-07T09:45:45Z

Thank you.

philiptaron · 2024-12-23T22:33:14Z

-    SetPythonProgramName("fontforge");
+    PyConfig config;
+    PyStatus status;
+    PyConfig_InitPythonConfig(&config);


Since this is an embedded usecase, should this be PyConfig_InitIsolatedConfig instead?

It depends on the behavior that you want. Isolated mode ignores env vars for example. I used Python mode to avoid behavior changes, only to use the new API.

Yes, not changing the behavior in a refactor makes a lot of sense.

I think there's an argument to changing from this current behavior, too, since it doesn't make too much sense to me to prioritize the current working directory to load (say) pkg_resources over what's in the system path, yet that's what's done today. (The first entry in sys.path is the empty string, which loads from the current directory.)

fontforge/fontforge/plugin.c

Lines 293 to 295 in 9af60ed

PyObject *pkgres = PyImport_ImportModule("pkg_resources");

if (pkgres == NULL || !PyObject_HasAttrString(pkgres, "iter_entry_points")) {

LogError(_("Core python package 'pkg_resources' not found: Cannot discover plugins\n"));

The current behavior has shades of DLL hijacking where running the application in the wrong directory causes unintentional code execution.

You may open a new issue since this PR is closed.

Thank you for the encouragement. I have opened #5515.

AC_PREREQ(2.70) downgraded to 2.69 for ELN distros, as explained here: fontforge/fontforge#5404 (comment)

vstinner force-pushed the pyconfig branch from a593298 to ef63c90 Compare August 5, 2024 09:26

vstinner force-pushed the pyconfig branch from ef63c90 to 010a287 Compare August 5, 2024 12:06

JoesCat added a commit to fontforge/libspiro that referenced this pull request Sep 3, 2024

LibSpiro 20240903 - Version 1.5.0

a2f38e1

AC_PREREQ(2.70) downgraded to 2.69 for ELN distros, as explained here: fontforge/fontforge#5404 (comment)

iorsh approved these changes Sep 5, 2024

View reviewed changes

Empty commit to trigger a CI job

bfaa05c

vstinner closed this Sep 25, 2024

vstinner reopened this Sep 25, 2024

skef approved these changes Oct 6, 2024

View reviewed changes

Call PyConfig_Clear(&config)

53aa875

skef merged commit 2f2ba54 into fontforge:master Oct 7, 2024

vstinner deleted the pyconfig branch October 7, 2024 09:45

iorsh mentioned this pull request Nov 24, 2024

Fontforge hardcodes dependency to deprecated Python module pkg_resources #5502

Closed

philiptaron reviewed Dec 23, 2024

View reviewed changes

spectral-smith97op added a commit to spectral-smith97op/libspiro that referenced this pull request Sep 28, 2025

LibSpiro 20240903 - Version 1.5.0

56e8b14

AC_PREREQ(2.70) downgraded to 2.69 for ELN distros, as explained here: fontforge/fontforge#5404 (comment)

iorsh mentioned this pull request Oct 10, 2025

Use importlib in plugin manager #5643

Merged

	PyObject *pkgres = PyImport_ImportModule("pkg_resources");
	if (pkgres == NULL \|\| !PyObject_HasAttrString(pkgres, "iter_entry_points")) {
	LogError(_("Core python package 'pkg_resources' not found: Cannot discover plugins\n"));

Conversation

vstinner commented Apr 18, 2024

Type of change

Uh oh!

iorsh commented Aug 3, 2024

Uh oh!

vstinner commented Aug 5, 2024

Uh oh!

myoresh commented Aug 5, 2024

Uh oh!

skef commented Aug 5, 2024

Uh oh!

iorsh commented Aug 5, 2024

Uh oh!

vstinner commented Aug 5, 2024

Uh oh!

vstinner commented Aug 5, 2024

Uh oh!

iorsh commented Aug 5, 2024

Uh oh!

skef commented Aug 5, 2024

Uh oh!

JoesCat commented Aug 5, 2024 via email

Uh oh!

vstinner commented Aug 5, 2024

Uh oh!

vstinner commented Sep 2, 2024

Uh oh!

iorsh commented Sep 3, 2024

Uh oh!

iorsh commented Sep 3, 2024

Uh oh!

iorsh commented Sep 3, 2024

Uh oh!

JoesCat commented Sep 3, 2024

Uh oh!

iorsh left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Sep 24, 2024

Uh oh!

iorsh commented Sep 24, 2024

Uh oh!

vstinner commented Sep 25, 2024

Uh oh!

vstinner commented Sep 25, 2024

Uh oh!

skef left a comment

Choose a reason for hiding this comment

Uh oh!

skef commented Oct 7, 2024

Uh oh!

vstinner commented Oct 7, 2024

Uh oh!

iorsh commented Oct 7, 2024

Uh oh!

skef commented Oct 7, 2024

Uh oh!

vstinner commented Oct 7, 2024

Uh oh!

philiptaron Dec 23, 2024

Choose a reason for hiding this comment

Uh oh!

vstinner Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

philiptaron Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

vstinner Dec 25, 2024

Choose a reason for hiding this comment

Uh oh!

philiptaron Dec 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone