Conversation
| FVChangeGID( sf->fv,i); | ||
| ff_post_error(_("Bad Multiple Master Font"),_("The %1$s hints in glyph \"%2$.30s\" in font %3$.30s do not match those in %4$.30s (different number or different overlap criteria)"), | ||
| "horizontal", sf->glyphs[i]->name,sf->fontname, mm->instances[j]->fontname); | ||
| _("horizontal"), sf->glyphs[i]->name,sf->fontname, mm->instances[j]->fontname); |
There was a problem hiding this comment.
Splitting localizable strings is a bad practice, as they cannot be reliably translated due to syntax differences. This string should be as follows:
_("The horizontal hints in glyph \"%1$.30s\" in font %2$.30s do not match those in %3$.30s (different number or different overlap criteria)"), sf->glyphs[i]->name,sf->fontname, mm->instances[j]->fontname
The other string below should be changed accordingly.
There was a problem hiding this comment.
Oh, yes! Especially in this case substitution makes no sense.
| FVChangeGID( sf->fv,i); | ||
| ff_post_error(_("Bad Multiple Master Font"),_("The glyph %1$.30s in font %2$.30s has a different set of kern pairs than in %3$.30s"), | ||
| "vertical", sf->glyphs[i]->name,sf->fontname, mm->instances[j]->fontname); | ||
| ff_post_error(_("Bad Multiple Master Font"),_("The glyph vertical in font %2$.30s has a different set of kern pairs than in %3$.30s"), |
There was a problem hiding this comment.
This string looks buggy at the first place - note that it used to have 3 parameters and 4 arguments. I think "vertical" should be just removed, the parameter %1$.30s is about glyph name, and it should be kept.
There was a problem hiding this comment.
Thank you so much! Didn't notice that.
|
Looks good to me now |
|
The checks aren't starting on this for some reason |
|
@slichtzzz can you push some trivial change to this branch? The checks are stuck and probably won't trigger without a commit. (You could just add two commits that make a change and then reverse it, for example.) |
|
macos 11 CI is dead https://github.com/fontforge/fontforgebuilds needs to be synced and #5423 merged to update the CI |
@jtanx resolved his own concern with an additional push
Corrected the situation, when substituted part of the string remains untranslated.
Corrected mistakes as per the reviewer's request
Corrected the situation, when substituted part of the string remains untranslated.
Type of change