Skip to content

Fix generated feature file bugs#5384

Merged
skef merged 7 commits intofontforge:masterfrom
nadalaba:fix-feature-file
Jun 24, 2024
Merged

Fix generated feature file bugs#5384
skef merged 7 commits intofontforge:masterfrom
nadalaba:fix-feature-file

Conversation

@nadalaba
Copy link
Copy Markdown
Contributor

@nadalaba nadalaba commented Mar 3, 2024

Fixes #5374
Fixes #5383
Replaces #5375

Comment thread fontforge/featurefile.c
@iorsh
Copy link
Copy Markdown
Contributor

iorsh commented Mar 3, 2024

Could you please add a unit test which covers the mentioned issues?

Comment thread fontforge/featurefile.c Outdated
Comment thread fontforge/featurefile.c Outdated
Comment thread fontforge/featurefile.c Outdated
Comment thread fontforge/featurefile.c
@nadalaba nadalaba requested review from iorsh and skef June 16, 2024 16:24
@iorsh
Copy link
Copy Markdown
Contributor

iorsh commented Jun 21, 2024

Looks good to me now

@skef skef merged commit 45d7441 into fontforge:master Jun 24, 2024
@nadalaba nadalaba deleted the fix-feature-file branch June 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants