Merged
Conversation
skef
approved these changes
Feb 4, 2024
Contributor
skef
left a comment
There was a problem hiding this comment.
This would be more portable if it were written in Python but the type of testing its doing is less likely to vary by platform, and anyway where bash isn't available by default one can figure things out, so this seems fine.
Contributor
Author
|
To test TTF export: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a BASH script, which can perform an operation on a large number of SFD files and compare its output to the reference FontForge version.
Specifically, for each SFD file in the list the following actions are performed:
/usr/local/bin/fontforgewith some script and keep the outputfontforgewith the same script and keep the output separatelyType of change
To verify this script actually works:
fontforge/fontforge/sfd.c
Line 7668 in eff88fc
sf->fullname = copyn(val, 23);. This change cuts long font names.