add `font.style_set_names` attribute to Python API by mf2vec-dev · Pull Request #5354 · fontforge/fontforge

mf2vec-dev · 2024-01-27T12:34:24Z

Closes #5263.

This PR adds the style_set_names attribute to the font type of the Python API to get and set the style set names (equivalent to Element -> Font Info... -> StyleSet Names in the GUI), including input validation, a Python test and documentation.

The last non-empty test case (name: "😀𝄞") passes in the Python interface. But when generating an sfd and loading it with the GUI, the name shown in the GUI is different (턞). I am not sure if this is a bug in my PR or an issue with SFDDumpUTF7Str/SFDReadUTF7Str or the GUI.
I would appreciate it if someone could double check this.

Type of change

New feature

Also add test for language give as int, use FindFlagByName instead of loop, check if font is closed, improve error messages and fix small bug.

iorsh · 2024-01-27T20:37:24Z

I tried to run your branch, but could see no data in Font Info -> StyleSet Names at all. Saved SFD font also has no entries for StyleSets. What is your system?

EDIT: Sorry, missed something in your test script. It's ok now.

iorsh · 2024-01-27T22:30:25Z

The issue with "😀𝄞" is a bug in SFDDumpUTF7Str/SFDReadUTF7Str. You can observe it regardless of your PR, by setting any name (for example in "Font Info" --> "TTF Names") with characters in a supplementary plane.

mf2vec-dev · 2024-01-28T07:17:12Z

The issue with "😀𝄞" is a bug in SFDDumpUTF7Str/SFDReadUTF7Str. You can observe it regardless of your PR, by setting any name (for example in "Font Info" --> "TTF Names") with characters in a supplementary plane.

@iorsh Correct, but I'm not 100% sure if it's SFDDumpUTF7Str/SFDReadUTF7Str or the GUI, because saving the font as sfd via Python and loading it with Python gives the correct language name "😀𝄞". So these Unicode characters seem to "survive" the sfd in this case.
Can you reproduce this?
(Perhaps a new issue would be a good place for this.)

BTW I'm using Ubuntu 22.04.3 LTS with Python 3.10.12.

iorsh · 2024-01-28T07:30:10Z

@iorsh Correct, but I'm not 100% sure if it's SFDDumpUTF7Str/SFDReadUTF7Str or the GUI, because saving the font as sfd via Python and loading it with Python gives the correct language name "😀𝄞". So these Unicode characters seem to "survive" the sfd in this case. Can you reproduce this? (Perhaps a new issue would be a good place for this.)

I couldn't reproduce this. Could you please specify the exact course of action or script?

mf2vec-dev · 2024-01-28T08:33:23Z

Could you please specify the exact course of action or script?

@iorsh This works for me:

import fontforge

style_set_names = (("English (British)", "ss20", "😀𝄞"),)
path = "/some/path/test.sfd" # change this

font = fontforge.font()
font.style_set_names = style_set_names
font.save(path)

font = fontforge.open(path)
assert font.style_set_names == style_set_names

The sfd file includes the line OtfFeatName: 'ss20' 2057 "+9gDRHgAA".

The GUI shows 턞 when you open it.

iorsh · 2024-01-28T08:42:32Z

Ah, you mean the assertion, which passes and indicates correctly loaded string. That's interesting, I'll take a look.

iorsh · 2024-01-28T15:06:52Z

If you add font.close() after saving, the assertion will fail. Probably fontforge.open() doesn't read file from disk if it's already open. So this is indeed a separate issue with SFDDumpUTF7Str/SFDReadUTF7Str.

Overall, I think we are good to go with this PR.

skef

LGTM

skef · 2024-02-01T07:12:51Z

@iorsh do you have any further comment on the recent changes before I merge this?

iorsh · 2024-02-01T07:21:05Z

@iorsh do you have any further comment on the recent changes before I merge this?

Looks good to me

add font.style_set_names attribute to Python API

d202229

dscorbett reviewed Jan 27, 2024

View reviewed changes

Comment thread fontforge/python.c

add digit check for tag_str

609d057

dscorbett reviewed Jan 27, 2024

View reviewed changes

Comment thread fontforge/python.c Outdated

Support lang ids in style_set_names' setter

c7202e7

Also add test for language give as int, use FindFlagByName instead of loop, check if font is closed, improve error messages and fix small bug.

iorsh reviewed Jan 27, 2024

View reviewed changes

Comment thread fontforge/python.c Outdated

use StrObjToTag and TagToPythonString

455a0e4

skef reviewed Jan 28, 2024

View reviewed changes

mf2vec-dev added 2 commits January 29, 2024 21:32

fix multiple bugs, add tests for raised error

e301a6a

Merge branch 'master' into py-font-style_set_names-attr

1357f49

skef reviewed Jan 30, 2024

View reviewed changes

Comment thread fontforge/python.c Outdated

Fix leak in PyFF_Font_set_style_set_names

67d19e5

skef approved these changes Feb 1, 2024

View reviewed changes

myoresh approved these changes Feb 1, 2024

View reviewed changes

skef merged commit eff88fc into fontforge:master Feb 1, 2024

delphinus mentioned this pull request Feb 1, 2024

StyleSet Names are empty delphinus/homebrew-sfmono-square#100

Open

mf2vec-dev deleted the py-font-style_set_names-attr branch February 1, 2024 17:05

iorsh mentioned this pull request Feb 2, 2024

Support suplementary planes in SFD (emojis etc.) #5364

Merged

Conversation

mf2vec-dev commented Jan 27, 2024

Type of change

Uh oh!

Uh oh!

Uh oh!

iorsh commented Jan 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

iorsh commented Jan 27, 2024

Uh oh!

mf2vec-dev commented Jan 28, 2024

Uh oh!

iorsh commented Jan 28, 2024

Uh oh!

mf2vec-dev commented Jan 28, 2024

Uh oh!

iorsh commented Jan 28, 2024

Uh oh!

iorsh commented Jan 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skef left a comment

Choose a reason for hiding this comment

Uh oh!

skef commented Feb 1, 2024

Uh oh!

iorsh commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iorsh commented Jan 27, 2024 •

edited

Loading