Skip to content

Fix crash in parsegvar() due to insufficient buffer#5339

Merged
skef merged 1 commit intofontforge:masterfrom
iorsh:fix_buffer
Jan 5, 2024
Merged

Fix crash in parsegvar() due to insufficient buffer#5339
skef merged 1 commit intofontforge:masterfrom
iorsh:fix_buffer

Conversation

@iorsh
Copy link
Copy Markdown
Contributor

@iorsh iorsh commented Jan 4, 2024

Fixes #5322 - see investigation in issue description

Notably, this is the only occurrence of sizeof(float) in the code.

Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skef skef merged commit 417800f into fontforge:master Jan 5, 2024
@iorsh iorsh deleted the fix_buffer branch January 5, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heap buffer overflow when reading TTF file

2 participants