Fix CI for Windows GitHub runner#5335
Conversation
|
@skef, the "linux (ubuntu-18.04, Release)" check is probably stalled because ubuntu-18.04 runner no longer exists (see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources). Earlier I updated runner in coverity.yml, but it didn't help. Apparently this is defined in some custom GitHub action, which I can't see. Could you please check? |
|
On the PR content: This extra binary gets us through the tests, but does it result in something that works? It doesn't appear (just from the changes) that we're installing that copy of the library in the respective module directory. If python modules are more limited in how they bind, we need to confirm we're within those limitations in the built product. |
|
Yes, that's tricky. Unfortunately, I don't have Windows machine to try this and see what works and what doesn't. I think the situation is somewhat similar to Mac, where I aligned everything to the same Python version (including subversion) to satisfy tests, but it would be ridiculous if a binary compiled with Python 3.11.7 actually breaks when installed on a system with 3.11.8. I don't have any solution for this except sweeping everything under the rug and waiting until somebody a) complains and b) agrees to help tuning the build with their environment. |
|
@iorsh File a new issue on the Windows build question and cross-link it here and I'll merge this. I found the stale status check and updated it to 20.04. |
|
Note that:
|
Ubuntu release cycle shows 18.04 has gone through 5 years. maybe consider bumping up to 20, and 22? |
|
@JoesCat I took care of that, the updated ones are "20.04" and "latest" |
Duplicate libfontforge.dll for "py" and "pyhook" tests.
Both
fontforge.exe(used in embedded Python tests) andpsMat.pyd, fontforge.pyd(used in Python hook tests) are looking forlibfontforge.dllstrictly in their respective directories. BothPATHenvironment variable and Python'ssys.pathseem to be ignored.