Skip to content

Fix CI for Windows GitHub runner#5335

Merged
skef merged 1 commit intofontforge:masterfrom
iorsh:ci_windows
Jan 2, 2024
Merged

Fix CI for Windows GitHub runner#5335
skef merged 1 commit intofontforge:masterfrom
iorsh:ci_windows

Conversation

@iorsh
Copy link
Copy Markdown
Contributor

@iorsh iorsh commented Jan 2, 2024

Duplicate libfontforge.dll for "py" and "pyhook" tests.

Both fontforge.exe (used in embedded Python tests) and psMat.pyd, fontforge.pyd (used in Python hook tests) are looking for libfontforge.dll strictly in their respective directories. Both PATH environment variable and Python's sys.path seem to be ignored.

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Jan 2, 2024

@skef, the "linux (ubuntu-18.04, Release)" check is probably stalled because ubuntu-18.04 runner no longer exists (see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources). Earlier I updated runner in coverity.yml, but it didn't help. Apparently this is defined in some custom GitHub action, which I can't see. Could you please check?

@skef
Copy link
Copy Markdown
Contributor

skef commented Jan 2, 2024

On the PR content: This extra binary gets us through the tests, but does it result in something that works? It doesn't appear (just from the changes) that we're installing that copy of the library in the respective module directory. If python modules are more limited in how they bind, we need to confirm we're within those limitations in the built product.

@iorsh
Copy link
Copy Markdown
Contributor Author

iorsh commented Jan 2, 2024

Yes, that's tricky. Unfortunately, I don't have Windows machine to try this and see what works and what doesn't. I think the situation is somewhat similar to Mac, where I aligned everything to the same Python version (including subversion) to satisfy tests, but it would be ridiculous if a binary compiled with Python 3.11.7 actually breaks when installed on a system with 3.11.8.

I don't have any solution for this except sweeping everything under the rug and waiting until somebody a) complains and b) agrees to help tuning the build with their environment.

@skef
Copy link
Copy Markdown
Contributor

skef commented Jan 2, 2024

@iorsh File a new issue on the Windows build question and cross-link it here and I'll merge this.

I found the stale status check and updated it to 20.04.

@skef
Copy link
Copy Markdown
Contributor

skef commented Jan 2, 2024

Note that:

  1. This praise-worthy revival of the repo will be almost all for naught if we can't do a release, which includes doing a Windows release
  2. I've seen evidence that the Jan 2023 Windows release is corrupt -- specifically that the wrong appearance configuration may have been included. If that's true then doing a new, corrected release to fix the Windows problem should be a project priority.

@JoesCat
Copy link
Copy Markdown
Contributor

JoesCat commented Jan 2, 2024

@skef, the "linux (ubuntu-18.04, Release)" check is probably stalled because ubuntu-18.04 runner no longer exists

Ubuntu release cycle shows 18.04 has gone through 5 years. maybe consider bumping up to 20, and 22?

@skef
Copy link
Copy Markdown
Contributor

skef commented Jan 2, 2024

@JoesCat I took care of that, the updated ones are "20.04" and "latest"

@iorsh iorsh mentioned this pull request Jan 2, 2024
4 tasks
Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skef skef merged commit 11647df into fontforge:master Jan 2, 2024
@iorsh iorsh deleted the ci_windows branch January 2, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants