Always set usDefaultChar to 0 (.notdef)#5242
Merged
skef merged 1 commit intofontforge:masterfrom Jan 28, 2024
Merged
Conversation
Contributor
|
@dscorbett, could you please rebase to the latest This generally looks safe to me. I couldn't see any specific Linux software incorrectly using "space" as a default character, but I recall such behavior in Windows. I agree that ".notdef" is better than "space", since it allows missing characters to stand out when displayed, instead of being quietly replaced with space. |
85ae7c0 to
9a064a3
Compare
Contributor
|
Per GW (224315a) is was a guess, so probably safe to sacrifice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usDefaultCharis the code point to use for a default glyph for an unsupported code point. If it is 0, the font uses glyph 0 (.notdef), which is always what you want instead of FontForge’s current behavior of defaulting to U+0020 SPACE.Type of change