fvmetrics.c: partial revert of 1033bc6#5167
Merged
ctrlcctrlv merged 1 commit intofontforge:masterfrom Dec 31, 2022
Merged
Conversation
Contributor
|
@ctrlcctrlv, would you review this one? It's going to take either of us a while to process the relevant code, but you have seen more of it than I have and probably have better test cases. |
Member
|
Yes, I can. |
Member
|
God, this part of the code is such a slog and has such a complicated history, but I think I understand it. The most important commit is bbde2a5 as that's where George tried to fix this originally in 2012 and is likely a good version, but it predates certain additions like To be certain, though, I did the following runtime tests: Given all that, I think this is fine to merge. It's certainly less broken than master, and I found no issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Fixes #4955
Type of change