Skip to content

Fix painting behaviour of the ruler linger window and layer change dialog#5163

Merged
jtanx merged 2 commits intofontforge:masterfrom
jtanx:gg
Dec 30, 2022
Merged

Fix painting behaviour of the ruler linger window and layer change dialog#5163
jtanx merged 2 commits intofontforge:masterfrom
jtanx:gg

Conversation

@jtanx
Copy link
Copy Markdown
Contributor

@jtanx jtanx commented Dec 30, 2022

Fixes #5119

Type of change

  • Bug fix

Comment thread fontforgeexe/cvruler.c
}
prev_rect = rect;
}
RulerLingerMove(cv); /* in case things are moving or scaling */
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling this from the expose event, I call it in response to the charview doing a scroll or zoom.

Copy link
Copy Markdown
Contributor

@skef skef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skef
Copy link
Copy Markdown
Contributor

skef commented Dec 30, 2022

This second commit looks OK too, given that the timer is set just before.

@jtanx jtanx merged commit eb78d6d into fontforge:master Dec 30, 2022
@jtanx jtanx deleted the gg branch December 30, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GGDKDraw assertion failure when using ruler

2 participants