Merged
Conversation
The typo resulted in the generation of complete gibberish when decrypting glyph charstrings.
A font's binary eexec ciphertext is followed by 512 clear text '0' characters which may be interspersed with white space characters. Typically, there is a newline character preceding the first '0'. The program was treating that newline as a final character of the ciphertext rather than as part of the white space.
Member
|
These changes seem reasonable to me and provided checks pass I'll merge them. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pfadecrypt T1 font decryption utility had a couple simple bugs that resulted gibberish when decoding a font. A bit more detail is given in the commit messages.
Type of change