parsettf.c: fix handling of invalid/0 CFF offsets#4669
Merged
jtanx merged 2 commits intofontforge:masterfrom Mar 19, 2021
Merged
parsettf.c: fix handling of invalid/0 CFF offsets#4669jtanx merged 2 commits intofontforge:masterfrom
jtanx merged 2 commits intofontforge:masterfrom
Conversation
Instead of checking against -1, check that the offset is greater than 0; a 0 offset would imply reading the same data again which doesn't make sense. Fixes fontforge#4667
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking against -1, check that the offset is greater
than 0; a 0 offset would imply reading the same data again which
doesn't make sense. (There are some cases which are special cased and 0 has some special meaning, I've left those alone and only changed ones which immediately fseek).
Fixes #4667
Type of change