fsys: resolve symlinks on Unix platforms#4626
fsys: resolve symlinks on Unix platforms#4626liushuyu wants to merge 1 commit intofontforge:masterfrom
Conversation
skef
left a comment
There was a problem hiding this comment.
This seems fine to me. Anyone else have concerns?
|
Can you explain a full example? imo if you want to resolve symlinks this should be done on the path to the fontforge binary itself instead of the folder containing fontforge (like there is a potential difference resolving |
This could happen in many Linux distro where Regarding your concern with the path resolution, I will change my patch to resolve the path to the binary. |
|
Which distro is this? Sounds more like a problem that if you symlink /bin to /usr/bin, then so too should /share to /usr/share |
| if ( (buf = realpath(program_dir, NULL)) ) { | ||
| free(program_dir); | ||
| program_dir = buf; | ||
| } |
There was a problem hiding this comment.
The whitespace is misaligned.
This will make
fontforgeresolve the symbolic links on the Unix platforms when loading its assets.This resolves the issue where if
fontforgeis invoked through symlink, it will not be able to load the resources.Type of change
This change is