Don't change to custom encoding on setting altuni#4598
Draft
skef wants to merge 1 commit intofontforge:masterfrom
Draft
Don't change to custom encoding on setting altuni#4598skef wants to merge 1 commit intofontforge:masterfrom
skef wants to merge 1 commit intofontforge:masterfrom
Conversation
when the encoding is already unicode compatible
Contributor
Author
|
At the time of filing this is a partial fix, because while it does eliminate the problem it doesn't cause the character in question to be displayed at the altuni-corresponding place(s) in the FontView. You can see this if you save the file and reopen it. I played around with various combinations of code to make that work and didn't have much luck. @frank-trampe any ideas? |
jtanx
reviewed
Oct 9, 2021
| if ( !IsUnicodeEncoding(fvs->map->enc, bmp_compat) ) { | ||
| fvs->map->enc = &custom; | ||
| FVSetTitle(fvs); | ||
| } // XXX else rebuild map? |
Contributor
There was a problem hiding this comment.
Is this this?
fontforge/fontforge/encoding.c
Line 2073 in 9dff1f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... when the encoding is already unicode compatible.
PyFF_Glyph_set_altuni()currently ends with:This is always executed no matter what the existing encoding. As far as I can see:
Anyway this is super-annoying when working with a script because (for example)
createMappedChar()stops working right after you add an altuni unless you set the encoding back to UnicodeBMP (for example) after every addition.