Update to "new menus" project #3637
Merged
skef merged 1 commit intofontforge:menus-2019from Apr 7, 2019
Merged
Conversation
Add BitmapView to new pattern Add BitmapView default hotkeys
Contributor
|
Glad to see someone picking this up again |
7 tasks
Member
|
I love it :) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important Note
This is a push request into the
menus-2019branch, not intomaster. I am submitting and self-approving this request for record-keeping purposes.This jumbo commit is my update of the
new-menusbranch last updated in 2015. It's preceded by a squash of that other branch.Contents
There are too many to mention -- see the commit for details. Highlights include:
NATIVE_CALLBACKSis supported, both kinds of scripts will be listed under the single menu, with a line between if there are some of both types.Changes from Earlier Documentation
I made a lot of judgment calls in completing this, so it doesn't completely match the documentation. A systemic account of the differences is also probably best accomplished by comparing the docs to code, but I'll list some things here:
Selectionmenu). This was the evident design intent. However, I made the area below View -> Former Glyph specific to the window type. (The documentation didn't really indicate what to do about it, the existing implementation hadn't addressed it yet, and this was the way that made sense.)I wrote some book-keeping helper scripts for myself, and while there are almost certainly typos and other mistakes still buried in here, I've confirmed that all functions present before in menus are present now. I've also gone through the Alt-accelerators (the underlines) and done my best to make them unique per-menu and (mostly) unified across the different windows. There are more hotkeys than supported in the current
masterbecause of the duplication of #3605 work.