How to implement "Add Inflection Points", "Tunnify" and "Harmonize" with menu entries? #4879
-
|
I am playing with the thought of implementing "Add Inflection Points", "Tunnify (Balance)" and "Harmonize" directly in FontForge with menu entries and then submitting an pull request. Before doing so, I have some questions:
My plan is to begin with "Add Inflection Points" because it works in a comparable manner as "Add Extrema". The function call hierarchy for the font view would be: FVMenuAddInflections -> FVAddInflections -> SplineCharAddInflections -> SplineSetAddInflections -> SplineAddInflections
Besides the font view menu there is also a char view menu and metrics view menu. It's clear that a char view menu entry does make sense for "Add Inflection".
I will add a translation for "Add Inflection Points" in the *.po files:
|
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 5 replies
-
|
The inflection points would be regular smooth points added wherever there is a horizontal or vertical inflection point on the curve? |
Beta Was this translation helpful? Give feedback.
-
|
I see that my comparison with "Add Extrema" was misleading: No, I meant to add regular smooth points on ANY inflection points on the curve (they do not have to be horizontal or vertical). It just works similar as "Add Extrema" with regards to input and output. |
Beta Was this translation helpful? Give feedback.
-
|
I should clarify that I have already written a Python plugin for FontForge at https://github.com/linusromer/curvatura that has these features. But now I want to implement the features in C for direct use in FontForge. |
Beta Was this translation helpful? Give feedback.
-
|
Hey, even if no FontForge user finds it useful (highly unlikely), Tunni lines and points have been on the MFEKglif wishlist for years (cf. MFEK/glif#19, MFEK/glif#20), and I can much easier convert C code for use from Rust than Python code (as I've already done for Spiro—MFEK/spiro-inner.rlib). Indeed, I was already planning on converting your merge function for use in MFEKglif, so, if you do this too it's just more for me to do at the time I do that. |
Beta Was this translation helpful? Give feedback.
-
|
@ctrlcctrlv I am not sure if the implementation in C helps more for Rust than the implementation in Python. It's probably easier to take the formulae from the Curvatura documentation for a new implementation in Rust. Meanwhile, I have tried to implement "Add points of inflections" as described above. It seems to work if I select the nodes before (which I will try to fix): |
Beta Was this translation helpful? Give feedback.
-
|
No, I'm sure it helps more, because of |
Beta Was this translation helpful? Give feedback.
-
|
I have made a pull request assuming the following answers: |
Beta Was this translation helpful? Give feedback.
-
|
The answers are given in #4900, which is merged. So I will close this question. |
Beta Was this translation helpful? Give feedback.
The answers are given in #4900, which is merged. So I will close this question.