fix(dropdown): encoded select values, multiple maxselections#2790
Merged
lubber-de merged 3 commits intofomantic:developfrom May 17, 2023
Merged
fix(dropdown): encoded select values, multiple maxselections#2790lubber-de merged 3 commits intofomantic:developfrom
lubber-de merged 3 commits intofomantic:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some dropdown fixes:
a) multiple and maxselections allowed more than the limit to be selected when labels are used
b) uselabels:false + saveremotedata:true und preselected values created labels
c) init from select and preselected value including an ampersand wasn't preselected
Testcase
a)
Broken
https://jsfiddle.net/lubber/1oeLn7h6/5/
Fixed
https://jsfiddle.net/lubber/1oeLn7h6/6/
b)
Broken
The dropdown shows 2 preselected labels, although labels should not be used
https://jsfiddle.net/lubber/c8eub9fo/2/
Fixed
"2 selected" shown as expected
https://jsfiddle.net/lubber/c8eub9fo/3/
c)
Broken
Dropdown made out of a select does not create the preselected labels which contains an ampersand
https://jsfiddle.net/lubber/qykf58tc/3/
Fixed
Preselected as expected
https://jsfiddle.net/lubber/qykf58tc/2/
Closes
#2782