Skip to content

fix(dropdown): encoded select values, multiple maxselections#2790

Merged
lubber-de merged 3 commits intofomantic:developfrom
lubber-de:dropdownFixes
May 17, 2023
Merged

fix(dropdown): encoded select values, multiple maxselections#2790
lubber-de merged 3 commits intofomantic:developfrom
lubber-de:dropdownFixes

Conversation

@lubber-de
Copy link
Copy Markdown
Member

@lubber-de lubber-de commented May 15, 2023

Description

Some dropdown fixes:
a) multiple and maxselections allowed more than the limit to be selected when labels are used
b) uselabels:false + saveremotedata:true und preselected values created labels
c) init from select and preselected value including an ampersand wasn't preselected

Testcase

a)

Broken

  • Open the dropdown via click on dropdown icon. Although the selection should be limited to 2 entries, you can add more entries
  • Clicking inside the dropdown does nothing
    https://jsfiddle.net/lubber/1oeLn7h6/5/

Fixed

b)

Broken

The dropdown shows 2 preselected labels, although labels should not be used
https://jsfiddle.net/lubber/c8eub9fo/2/

Fixed

"2 selected" shown as expected
https://jsfiddle.net/lubber/c8eub9fo/3/

c)

Broken

Dropdown made out of a select does not create the preselected labels which contains an ampersand
https://jsfiddle.net/lubber/qykf58tc/3/

Fixed

Preselected as expected
https://jsfiddle.net/lubber/qykf58tc/2/

Closes

#2782

@auto-assign auto-assign bot requested review from ColinFrick, ko2in and prudho May 15, 2023 21:27
@lubber-de lubber-de requested a review from y0hami May 15, 2023 21:27
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-reviews Pull requests which are waiting for reviews javascript labels May 15, 2023
@lubber-de lubber-de added this to the 2.9.3 milestone May 15, 2023
Copy link
Copy Markdown
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lubber-de lubber-de merged commit 34abb0e into fomantic:develop May 17, 2023
@lubber-de lubber-de deleted the dropdownFixes branch May 17, 2023 09:44
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label May 17, 2023
@lubber-de lubber-de added lang/javascript Anything involving JavaScript and removed javascript labels Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants