fix(tab): do not auto activate tabs more than once#1025
Merged
y0hami merged 1 commit intofomantic:developfrom Sep 19, 2019
Merged
fix(tab): do not auto activate tabs more than once#1025y0hami merged 1 commit intofomantic:developfrom
y0hami merged 1 commit intofomantic:developfrom
Conversation
ColinFrick
approved these changes
Sep 19, 2019
lubber-de
approved these changes
Sep 19, 2019
Member
lubber-de
left a comment
There was a problem hiding this comment.
LGTM, i added another jsfiddle to the description with the current fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My previous PR #977 introduced auto activation for no specified tab. Except that each time you call the
.tab()method for one of thoses tabs, it checks again and change the active one...This fix just consist of checking if tabs were initializes before, so it doesn't have to recheck again...
Testcase
JSFiddle
JSFiddle (Fixed)
Closes
#1014