-
-
Notifications
You must be signed in to change notification settings - Fork 335
[build] Local Python is currently required to be locally available #3167
Copy link
Copy link
Closed
Labels
priority/highAnything which is in high priorityAnything which is in high prioritytype/bugAny issue which is a bug or PR which fixes a bugAny issue which is a bug or PR which fixes a bugtype/upstreamAny issues in dependenciesAny issues in dependencies
Milestone
Description
Bug Report
I tried to update Fomantic UI code for atk4/ui and I found some deps were raised and the deps caused local Python is currently needed to pass a build!
npm ERR! > re2@1.20.5 rebuild
npm ERR! > node-gyp rebuild
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using node-gyp@9.4.1
npm ERR! gyp info using node@19.8.1 | win32 | x64
npm ERR! gyp ERR! find Python
...
I figured out it is caused by:
https://github.com/fomantic/Fomantic-UI/blob/2f37293a27/package.json#L47
->
https://github.com/fomantic/gulp-concat-css/blob/3.2.1/package.json#L27
->
https://github.com/fomantic/rework-import/blob/3.1.0/package.json#L31
->
https://github.com/uhop/node-re2/blob/1.20.5/package.json#L16
This is very problematic for my build machine as I am on Windows without Python available on my setup.
I belive there is a way to not require re2 dependency and use PCRE/JS regexes instead.
Steps to reproduce
{
"name": "atk-external",
"private": true,
"dependencies": {
"fomantic-ui": "^2.9.4-beta"
}
}
Expected result
No Python nor other executable required as before.
Version
2.9.4 nightly / current develop
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority/highAnything which is in high priorityAnything which is in high prioritytype/bugAny issue which is a bug or PR which fixes a bugAny issue which is a bug or PR which fixes a bugtype/upstreamAny issues in dependenciesAny issues in dependencies