fix(dropdown): make "set text" work for custom actions

lubber-de · web-flow · commit e4ff5533efb6 · 2023-12-19T19:28:45.000+01:00
The set text behavior was not working for custom actions whereas such function internally calls the "set text" method.
This PR also fixes showing all items before hiding when a non-multiple dropdown allowed additions
diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js
@@ -1413,7 +1413,9 @@
                                         module.remove.userAddition();
                                     }
                                     if (!settings.keepSearchTerm) {
-                                        module.remove.filteredItem();
+                                        if (module.is.multiple()) {
+                                            module.remove.filteredItem();
+                                        }
                                         module.remove.searchTerm();
                                     }
                                     if (!module.is.visible() && $target.length > 0) {
@@ -2587,7 +2589,7 @@
                             } else {
                                 $combo.text(text);
                             }
-                        } else if (settings.action === 'activate') {
+                        } else if (settings.action === 'activate' || isFunction(settings.action)) {
                             if (text !== module.get.placeholderText() || isNotPlaceholder) {
                                 $text.removeClass(className.placeholder);
                             }

Original file line number	Diff line number	Diff line change
`@@ -1413,7 +1413,9 @@`
`1413`	`1413`	`module.remove.userAddition();`
`1414`	`1414`	`}`
`1415`	`1415`	`if (!settings.keepSearchTerm) {`
`1416`		`- module.remove.filteredItem();`
	`1416`	`+ if (module.is.multiple()) {`
	`1417`	`+ module.remove.filteredItem();`
	`1418`	`+ }`
`1417`	`1419`	`module.remove.searchTerm();`
`1418`	`1420`	`}`
`1419`	`1421`	`if (!module.is.visible() && $target.length > 0) {`
`@@ -2587,7 +2589,7 @@`
`2587`	`2589`	`} else {`
`2588`	`2590`	`$combo.text(text);`
`2589`	`2591`	`}`
`2590`		`- } else if (settings.action === 'activate') {`
	`2592`	`+ } else if (settings.action === 'activate' \|\| isFunction(settings.action)) {`
`2591`	`2593`	`if (text !== module.get.placeholderText() \|\| isNotPlaceholder) {`
`2592`	`2594`	`$text.removeClass(className.placeholder);`
`2593`	`2595`	`}`