fix: read conceal setting after sorting#558
Merged
folke merged 1 commit intofolke:mainfrom Aug 29, 2023
MariaSolOs:conceal-offset
Merged
fix: read conceal setting after sorting#558folke merged 1 commit intofolke:mainfrom MariaSolOs:conceal-offset
folke merged 1 commit intofolke:mainfrom
MariaSolOs:conceal-offset
Conversation
Owner
|
Thank you for the PR! I'm leaving on vacation this evening, so won't have time to look at it till I'm back. End of August. Thanks again! |
Contributor
Author
|
@folke no worries, enjoy your vacation! 🏝️ |
Contributor
Author
|
@folke sorry for the ping, but are there any chances of having this merged soonish? 😺 |
Owner
|
thanks! |
Contributor
Author
|
@folke thanks to you! (for your patience with my endless issues and PRs to your plugins lol) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #557
The explanation of the fix is that if
format.concealistrue, then all offsets are set to 0 and then the matched pattern won't be the longest one (so if one types:lua, the pattern for^:matches instead of^:lua). Once sorting is done, then the offset is correctly applied based onformat.conceal.I manually tested this with and without concealing but I might appreciate a quick sanity check ;) @folke