#1486 fix newline items in lists#1487
Merged
blikblum merged 5 commits intofoliojs:masterfrom Dec 22, 2023
Merged
Conversation
|
Unfortunately this merge destroyed numbered lists feature. Numbers are always |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #1486 by no longer using a newline character to separate list items, but actually print each list item in a single function and correctly respecting newlines of a list item.
Prior to this change,
\nwas used to separate list items, causing an unexpected number of bullet points when a list item contained a line break as well.This PR also introduces a visual test for lists with different line break characters.
Checklist: