Skip to content

[#982] Pin nwsapi downstream jsdom dependency to v2.2.2#995

Merged
stefcameron merged 1 commit into
masterfrom
nwsapi
May 3, 2023
Merged

[#982] Pin nwsapi downstream jsdom dependency to v2.2.2#995
stefcameron merged 1 commit into
masterfrom
nwsapi

Conversation

@stefcameron

@stefcameron stefcameron commented May 3, 2023

Copy link
Copy Markdown
Member

Fixes #982

Tested locally by cloning this repo and then:

$ rm package-lock.json
$ npm install # regenerates package-lock.json
$ npm test # fails because of nwsapi issues post-v2.2.2
# edit package.json to add override clause
$ npm install # results in nwsapi@2.2.2
$ npm test # succeeds
PR Checklist

Please leave this checklist in your PR.

  • Source changes maintain stated browser compatibility.
  • Issue being fixed is referenced.
  • Unit test coverage added/updated.
  • E2E test coverage added/updated.
  • Typings added/updated.
  • Changes do not break SSR:
    • Careful to test typeof document/window !== 'undefined' before using it in code that gets executed on load.
  • README updated (API changes, instructions, etc.).
  • Changes to dependencies explained.
  • Changeset added (run npm run changeset locally to add one, and follow the prompts).
    • EXCEPTION: A Changeset is not required if the change does not affect any of the source files that produce the package bundle. For example, demo changes, tooling changes, test updates, or a new dev-only dependency to run tests more efficiently should not have a Changeset since it will not affect package consumers.

@changeset-bot

changeset-bot Bot commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4bdffac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
tabbable Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented May 3, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (aeca1d2) 97.99% compared to head (4fb2b6b) 97.99%.

❗ Current head 4fb2b6b differs from pull request most recent head 4bdffac. Consider uploading reports for the commit 4bdffac to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #995   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files           1        1           
  Lines         249      249           
  Branches      121      121           
=======================================
  Hits          244      244           
  Misses          5        5

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefcameron stefcameron merged commit b39b217 into master May 3, 2023
@stefcameron stefcameron deleted the nwsapi branch May 3, 2023 22:50
@stefcameron stefcameron mentioned this pull request May 3, 2023
Closed
@stefcameron

stefcameron commented May 8, 2023

Copy link
Copy Markdown
Member Author

Published in tabbable v6.1.2

@stefcameron stefcameron mentioned this pull request May 8, 2023
Closed
@stefcameron stefcameron mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jsdom issue: 'slot):not([inert]' is not a valid selector

1 participant

@stefcameron