Merged
Conversation
Collaborator
|
@bbenjamin I'm not actively developing this project, so it would be great if you'd like to take over maintenance (I can add you as a collaborator) or fork it! |
Closed
stefcameron
approved these changes
Aug 22, 2020
Member
stefcameron
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding this target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm evaluating replacements for jQuery UI's
:tabbablein Drupal core, since jQueryUI is end-of-life. I have a strong preference for tabbable, but to be used in Drupal it would needs to be available as a global variable definition. The UMD files generated by this patch work great in Drupal, so I'm hoping you're open to adding this as an option.Also happy to assist on other issues that the next release is waiting on.