Update ALL dependencies to latest versions#78
Merged
stefcameron merged 1 commit intofocus-trap:masterfrom Jun 29, 2020
stefcameron:dep-updates
Merged
Update ALL dependencies to latest versions#78stefcameron merged 1 commit intofocus-trap:masterfrom stefcameron:dep-updates
stefcameron merged 1 commit intofocus-trap:masterfrom
stefcameron:dep-updates
Conversation
- All dependencies have been updated to their very latest versions. Some were dropped in favor of more modern ones (in particular, related to Babel 6.x -> 7.x). - Added ESLint Prettier rules. - Updated Prettier to 2.x, configured options, formatted code. - Fixed a bug that was causing a crash expecting `includes()` to be a method on `specifiedFocusTrapOptions`. - Added babel-jest to remove the need to first build the bundle prior to running tests. - Added format-check package script to check for formatting issues. - Added format and lint checks to `npm test`, along with unit tests. - Some lint errors were disabled, deferred to #77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some were dropped in favor of more modern ones (in particular,
related to Babel 6.x -> 7.x).
includes()to be a method on
specifiedFocusTrapOptions.prior to running tests.
npm test, along with unit tests.