upgrade e2e and enable firefox#206
Conversation
|
1827905 to
f4a845b
Compare
| browser: [chrome, firefox] | ||
| container: | ||
| image: cypress/included:6.0.1 | ||
| options: --user 1001 |
There was a problem hiding this comment.
Per official cypress git action example for Firefox: https://github.com/cypress-io/github-action#firefox
| - uses: actions/checkout@v1 | ||
| - uses: cypress-io/github-action@v2.6.1 | ||
| with: | ||
| start: yarn start | ||
| browser: ${{ matrix.browser }} |
There was a problem hiding this comment.
This is the suggested git action way to run cypress test on CI by bamutov
|
One comment out of this change but I just thinked about at the trigger condition of e2e test https://github.com/focus-trap/focus-trap-react/pull/206/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR6 on:
push:
branches:
- 'master'Do we benefit from running e2e at every commit push so submitter can find out real browser issue much earlier than PR creation? I feel this repo e2e is really fast. |
|
If the change is good I will also port this to the base repo |
stefcameron
left a comment
There was a problem hiding this comment.
Fantastic! Thanks for keeping track of the Cypress FF issue. 🎉
AFAIK, the CI action is configured such that it will run for any PR update (whether you force-push the branch or add another commit) as well as on master for all merges/commits to master. Are you seeing something different? |
Yes, please do! |
|
FYI, I have now made the FF e2e tests in CI mandatory, as in must pass before merging. |
Features and Bug Fixes
- [ ] Issue being fixed is referenced.- [ ] Unit test coverage added/updated.- [ ] E2E test coverage added/updated.- [ ] Prop-types added/updated.- [ ] Typings added/updated.- [ ] README updated (API changes, instructions, etc.).- [ ] Changes to dependencies explained.- [ ] Changeset added (runyarn changesetlocally to add one, follow prompts).Tooling
- [ ] README instructions updated.DONE
cypress/included:5.0.0cypress-io/cypress-docker-images#363 and also E2E testing on major browsers #104package.jsondevDependencies