Update all dependencies, move to yarn/Webpack and GitHub CI#125
Merged
stefcameron merged 3 commits intomasterfrom Aug 17, 2020
Merged
Update all dependencies, move to yarn/Webpack and GitHub CI#125stefcameron merged 3 commits intomasterfrom
stefcameron merged 3 commits intomasterfrom
Conversation
dce48b2 to
5e1a299
Compare
5e1a299 to
5ac26d2
Compare
Fixes #124 to put this repo inline with focus-trap-react: - update all deps to latest versions - move to yarn with yarn.lock - use Webpack to build instead of Browserify (see below for more details) - update Prettier and run on all the source (same rules as focus-trap-react) - add check for types so that problems like #123 don't happen again - (*) fixes bug in package.json 'main' that wasn't pointing to /dist/focus-trap.js (build output) Because of (*) this should be published as a new __major__ release, just to be safe, even though there shouldn't be any breaking changes as a result (famous last words...). This should also close-out a bunch of the security-related notices on the repo from Dependabot because of old package versions with vulnerabilities. Added Webpack builds and removed some deps: - Webpack Dev and Prod builds, mimicing old Browserify builds. - Removed Browserify: Webpack replaces. - Removed uglify: Webpack takes care of this now. - Removed xtend: simple ES6 object merging works fine. Fixed 2 small bugs: - Fixed bug on line 316 of index.js where an NPE would happen if the trap was created without `userOptions`; should be `config.preventScroll` instead since we create `config` early on within the module and use that everywhere instead of `userOptions`. - Fixed bug in allow-click-outside demo by disabling ESC: Otherwise, the 'activate trap' button state would get out of sync with the state of the trap (would remain 'deactivate trap' after pressing ESC). NOTE: Publishing is still done manually from a local repo. If we move this repo to Changesets later, we can start doing releases via GitHub Actions like `focus-trap-react`.
5ac26d2 to
101c452
Compare
3 tasks
maraisr
approved these changes
Aug 17, 2020
maraisr
left a comment
There was a problem hiding this comment.
WoW nice one mate, yeah will do the whole changesets thing. And maybe simplify our build too
Member
Author
Thanks! Sounds good. What I did here, I will now do over on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124 to put this repo inline with focus-trap-react:
for more details)
focus-trap-react)
happen again
/dist/focus-trap.js (build output)
Because of (*) this should be published as a new major release,
just to be safe, even though there shouldn't be any breaking
changes as a result (famous last words...).
This should also close-out a bunch of the security-related
notices on the repo from Dependabot because of old package
versions with vulnerabilities.
Added Webpack builds and removed some deps:
Fixed 2 small bugs:
if the trap was created without
userOptions; should beconfig.preventScrollinstead since we createconfigearlyon within the module and use that everywhere instead of
userOptions.the 'activate trap' button state would get out of sync with
the state of the trap (would remain 'deactivate trap' after
pressing ESC).
NOTE: Publishing is still done manually from a local repo.
If we move this repo to Changesets later, we can start
doing releases via GitHub Actions like
focus-trap-react.