Fixes for libretro on Mac#885
Merged
flyinghead merged 5 commits intoflyinghead:masterfrom Jan 20, 2023
Merged
Conversation
Contributor
Author
|
In posix_vmem.cpp's allocate_shared_filemem(), if the user data dir has not been set, the path that tries to get opened on OSX is just |
Owner
|
The reason why you can't call This is a problem for libretro when the core is not unloaded after You can have a look at the changes in libretro.cpp in e0058c1. Adding APPLE to the list would probably fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static variables can get left around and reused following dlclose/dlopen (the manpage for dlclose is deliberately unclear about whether that will happen). RetroArch on OSX crashes when trying to load flycast a second time because the core fails to reinitialize, because it thinks it is terminated.