Skip to content

Various GDB fixes and improvements#832

Merged
flyinghead merged 7 commits intoflyinghead:devfrom
BigEvilCorporation:gdb-improvements-1
Dec 16, 2022
Merged

Various GDB fixes and improvements#832
flyinghead merged 7 commits intoflyinghead:devfrom
BigEvilCorporation:gdb-improvements-1

Conversation

@BigEvilCorporation
Copy link
Contributor

@BigEvilCorporation BigEvilCorporation commented Dec 16, 2022 •
edited
Loading

  1. Enabled GDB server, compile fix for MSVC, added GDB option to config
  2. Fixed handling of unknown vpackets (and vMustReplyEmpty should be "unknown", it exists to test this behaviour)
  3. Added a GDBWaitForConnection option to allow for debugging from bootstrap/main()
  4. Fixed UI to allow for "Waiting for debugger" and other final frames before a UI state change (e.g., progress bars should now reach 100% instead of 99%)
  5. Fixed endianness of registers and memory send to/from GDB - backtrace and frame disassembly now working correctly as a result

@flyinghead
Copy link
Owner

flyinghead commented Dec 16, 2022

I would prefer to have ENABLE_GDB_SERVER to default to OFF. As you mentioned in an earlier PR there is a performance hit when gdb is enabled. It's mostly in the interpreter, where it isn't really an issue, but it's also called by Do_Interrupt and Do_Exception that are used very frequently.

Then the test if(LIBRETRO OR WINDOWS_STORE OR ANDROID OR IOS) to disable gdb on these platforms is no longer needed.

Everything else looks good to me

@flyinghead flyinghead merged commit b0a520f into flyinghead:dev Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BigEvilCorporation @flyinghead