cmake: execute git commands in the source directory#765
Merged
flyinghead merged 1 commit intoflyinghead:masterfrom Oct 5, 2022
pjagiello:master
Merged
cmake: execute git commands in the source directory#765flyinghead merged 1 commit intoflyinghead:masterfrom pjagiello:master
flyinghead merged 1 commit intoflyinghead:masterfrom
pjagiello:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while wondering why "About" screen shows a commit hash that doesn't seem to exist - turns out if you run CMake with the -S option to point at a directory with the source, then the git commands execute in the directory you ran the cmake command in, instead of in the repository directory.
This can fail or even succeed with a hash from an unrelated repository (in my case this is what happened, it fetched the hash of the AUR package instead, and funnily enough I'm not the only person this happened to, see last video on this list ).