CMake: fix build on Windows with OpenMP#1800
Merged
flyinghead merged 1 commit intoflyinghead:masterfrom Jan 6, 2025
oltolm:cmake
Merged
CMake: fix build on Windows with OpenMP#1800flyinghead merged 1 commit intoflyinghead:masterfrom oltolm:cmake
flyinghead merged 1 commit intoflyinghead:masterfrom
oltolm:cmake
Conversation
Contributor
Author
|
I had to revert my CMake improvements because the build fails on other systems. Now it just contains a fix for building on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I fixed the build with OpenMP on Windows and slightly improved the
CMakeLists.txtby introducing separate libraries for picotcp, lzma_deps and ggpo.