Skip to content

Fix cable connection for left and right node pin#233

Merged
GabiGrin merged 1 commit intoflydelabs:mainfrom
privatestefans:fix/cable-connection-ui/s-curve
Jul 4, 2025
Merged

Fix cable connection for left and right node pin#233
GabiGrin merged 1 commit intoflydelabs:mainfrom
privatestefans:fix/cable-connection-ui/s-curve

Conversation

@privatestefans
Copy link
Copy Markdown
Contributor

Summary

  • Use different calculation approach for seamless S-bezier curve (for left and right node pin only)
  • Normalize S-curve cable when the pin is near

Preview after fixed

Code_ygpmGOL6YW.mp4

Linked

/claim #208
/closes #208

@GabiGrin
Copy link
Copy Markdown
Contributor

GabiGrin commented Jul 4, 2025

Hey @privatestefans, the code and video look great! testing it now and will approve soon

@GabiGrin GabiGrin merged commit 2c5e8e4 into flydelabs:main Jul 4, 2025
1 check passed
@GabiGrin
Copy link
Copy Markdown
Contributor

GabiGrin commented Jul 4, 2025

looks perfect, thanks!

@GabiGrin
Copy link
Copy Markdown
Contributor

GabiGrin commented Jul 4, 2025

@privatestefans Bounty rewarded ✅

@privatestefans
Copy link
Copy Markdown
Contributor Author

That was fast, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connections - connections look bad when pins are vertically aligned

2 participants