chore: Improvements in Hovering and Selecting Pins and Nodes#213
Conversation
Updated the node header selection styles. Added styles to help distinguish between hovering a pin and a node.
|
Thanks @Wr4th100! Code looks good, gonna play with it locally now |
GabiGrin
left a comment
There was a problem hiding this comment.
@Wr4th100 when hovering the node and not a pin, the icon shouldn't be grayed out.
The "effect" should only be triggered if a pin is on hover.
See TW's group helper for a possible direction - https://tailwindcss.com/docs/hover-focus-and-other-states#styling-based-on-parent-state
…r4th100/flyde into Wr4th100/hover-and-select-improvements
I have made the changes @GabiGrin . Does this look right? iconhoverchanges.mp4 |
|
Almost :) the other pins should be dimmed also only if a pin is hovered. |
GabiGrin
left a comment
There was a problem hiding this comment.
the other pins should be dimmed also only if a pin is hovered.
The motivation is to make it clear that a pin is hovered, but not hurt readability when the node itself is.
Yes, that was bugging me for a while... I have updated the code accordingly. This is how it looks now: nodeselectionchanges.mp4 |
/claim #207
/closes #207
Changes
Screenshots:
Node Selection (Dark)
Node Selection (Light)
Hovering over a pin and a node (Video)
video.mp4