Skip to content

cherry-pick #846#850

Merged
darkowlzz merged 1 commit intorelease/v0.25.xfrom
846-cherry-pick
Jul 27, 2022
Merged

cherry-pick #846#850
darkowlzz merged 1 commit intorelease/v0.25.xfrom
846-cherry-pick

Conversation

@darkowlzz
Copy link
Copy Markdown
Contributor

@darkowlzz darkowlzz commented Jul 27, 2022

cherry-pick #846 to release/v0.25.x

Taking this shortcut has two benefits:

1. It allows charts to be fetched from AWS's public container registry
   at public.ecr.aws
2. It makes reconciling a HelmChart faster by skipping one or more
   potentially expensive API calls to the registry.

I adapted the unit tests to the new behavior that the
OCIChartRepository doesn't fail anymore for the case where a specific
chart version has been requested that doesn't actually exist in the
registry.

refs #845

Signed-off-by: Max Jonas Werner <max@e13.dev>
Signed-off-by: Sunny <darkowlzz@protonmail.com>
@darkowlzz darkowlzz merged commit 3c69f3a into release/v0.25.x Jul 27, 2022
@darkowlzz darkowlzz deleted the 846-cherry-pick branch July 27, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants