Skip to content

Conversation

@Boehrsi
Copy link
Contributor

@Boehrsi Boehrsi commented Oct 7, 2021

Description

Updated the documentation to state the inability to share data to Facebook apps. As this PR contains only documentation changes I haven't updated the change log.

Related Issues

Closes #413

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 7, 2021
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As I understand this is an issue for Android and iOS right? could you specify that (although may be obvious for some)

@Boehrsi Boehrsi force-pushed the 413_facebook_sharing branch from 48f0346 to afe752f Compare October 7, 2021 18:28
@Boehrsi
Copy link
Contributor Author

Boehrsi commented Oct 7, 2021

Had to force push, as I discovered (happily before merging this PR) that I initially edited the readme file of the package_plus project and not sharing_plus. I fixed this and also added clarification in regards to the platforms.

@miquelbeltran miquelbeltran merged commit d983779 into fluttercommunity:main Oct 8, 2021
@Boehrsi Boehrsi deleted the 413_facebook_sharing branch October 9, 2021 14:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[share_plus] share() result in empty message in Facebook News Feed

2 participants