[in_app_purchase] Migrate to Billing to 5.0.0#5405
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| androidTestImplementation 'androidx.test:runner:1.1.1' | ||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1' | ||
| implementation 'androidx.annotation:annotation:1.3.0' | ||
| implementation 'com.android.billingclient:billing:4.1.0' |
There was a problem hiding this comment.
this will probably need more testing from our side, as well as exposing new APIs described in the changelog since 3.0.2
|
directly Migrate to Google Play Billing Library 5.0 could make sense |
|
Yes, The title needs to be changed, I am directly migrating to 5.0. 5.0 was released midway through my 4.1 migration implementation |
|
Manually validated the billing flows with the example app. @blasten Ready for review |
| // `sku` was deprecated in billion 4.0, but we cannot directly remove it from our | ||
| // API instantly. Thus, for backwards compatibility, we pass the first sku here | ||
| // and include the rest of the list under `skus`. | ||
| if (!skus.isEmpty()) { |
There was a problem hiding this comment.
Would it be easier to cleanup later if we put this logic to the dart side.
Then we don't have to cleanup the java code when we remove .sku.
There was a problem hiding this comment.
Yeah, makes sense, I'll do that
|
|
||
| /// The product ID of this purchase. | ||
| @JsonKey(defaultValue: '') | ||
| @Deprecated('Use skus instead') |
There was a problem hiding this comment.
If we move the logic to dart, sku would be skus.first
|
@cyanglaz Versioning and comments addressed. This needs a github "approve" to move forwards :) thanks! |
| required this.purchaseToken, | ||
| required this.signature, | ||
| required this.sku, | ||
| @Deprecated('Use skus instead') String? sku, |
There was a problem hiding this comment.
I think we need to update the shared plugin to use the new field instead. Should be in a new PR after this is published
|
Please let us know when this pull is going to be merged. We urgently need to migrate to billing version 4.0. We can't push updates to our app without migrating to version 4.0 |
Bumps the android dependency versions of in_app_purchase
Fixes flutter/flutter#88664