This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] Ensure full transform is applied to glyphs#54398
Merged
auto-submit[bot] merged 2 commits intoAug 12, 2024
Merged
Conversation
added 2 commits
August 7, 2024 10:27
…-team-archive#53819) Fixes flutter/flutter#151521 My change made the text size absorb the scale, so I wasn't applying the full transform. That is incorrect if there are negative scales.
…pixels when computing text positions. (flutter-team-archive#54015) Dividing then multipliying can lead to position values like 432.99987 which end up losing a pixel.
zanderso
approved these changes
Aug 7, 2024
2d6a7f8
into
flutter-team-archive:flutter-3.24-candidate.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that RTL glyphs render correctly.