This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove NOLINT on entity_pass.cc.#47316
Closed
zanderso wants to merge 1 commit into
Closed
Conversation
We've had a few clang rolls since linting this file was causing timeouts. This PR removes the NOLINT to see if we still hit this issue on CI. If the NOLINT needs to be added back, the linked issue should be updated to flutter/flutter#132417. Fixes flutter/flutter#132417
flar
reviewed
Oct 25, 2023
flar
left a comment
Contributor
There was a problem hiding this comment.
Love it, but now the code needs lint fixes. :(
chinmaygarde
approved these changes
Oct 25, 2023
Contributor
|
Looks like the errors are real. |
Contributor
|
Looks like the errors will go away after #47347. Will rebase and recheck after that point. |
Contributor
Author
|
Closing as obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had a few clang rolls since linting this file was causing timeouts. This PR removes the NOLINT to see if we still hit this issue on CI.
If the NOLINT needs to be added back, the linked issue should be updated to flutter/flutter#132417.
Fixes flutter/flutter#132417
@flar @gaaclarke @matanlurey