Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

CP: Add drone_dimensions as top level target property. (#42064)#42067

Merged
godofredoc merged 1 commit into
flutter-team-archive:flutter-3.11-candidate.0from
godofredoc:flutter-3.11-candidate.0
May 16, 2023
Merged

CP: Add drone_dimensions as top level target property. (#42064)#42067
godofredoc merged 1 commit into
flutter-team-archive:flutter-3.11-candidate.0from
godofredoc:flutter-3.11-candidate.0

Conversation

@godofredoc

Copy link
Copy Markdown
Contributor

CP: 27e0a73

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is to make the configs easier to use for builders running from a drone.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@godofredoc godofredoc requested a review from XilaiZhang May 16, 2023 03:34

@XilaiZhang XilaiZhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc merged commit 60044d1 into flutter-team-archive:flutter-3.11-candidate.0 May 16, 2023
@godofredoc godofredoc deleted the flutter-3.11-candidate.0 branch May 16, 2023 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants