Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] [Impeller] Retain embolden/skew font properties when rendering text g…#39424

Merged
godofredoc merged 2 commits into
flutter-team-archive:flutter-3.7-candidate.1from
zanderso:impeller-weight-skew-cp
Feb 7, 2023
Merged

[CP] [Impeller] Retain embolden/skew font properties when rendering text g…#39424
godofredoc merged 2 commits into
flutter-team-archive:flutter-3.7-candidate.1from
zanderso:impeller-weight-skew-cp

Conversation

@zanderso

@zanderso zanderso commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

CP of 4fdbb0a to fix flutter/flutter#119489 for flutter-3.7-candidate.1

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso changed the title [Impeller] Retain embolden/skew font properties when rendering text g… [CP] [Impeller] Retain embolden/skew font properties when rendering text g… Feb 6, 2023
@zanderso

zanderso commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

Presubs are affected by flutter/flutter#120093

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc

Copy link
Copy Markdown
Contributor

@zanderso can you please rebase this change? it will help to pass all the presubmit checks.

@zanderso zanderso force-pushed the impeller-weight-skew-cp branch from 7ea649a to c0145e4 Compare February 7, 2023 21:55
@zanderso

zanderso commented Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

@zanderso can you please rebase this change? it will help to pass all the presubmit checks.

Done

@godofredoc godofredoc merged commit 3b5c7a1 into flutter-team-archive:flutter-3.7-candidate.1 Feb 7, 2023
@zanderso zanderso deleted the impeller-weight-skew-cp branch February 7, 2023 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

4 participants