Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] 3.7 platform view cliprrect#38988

Merged
godofredoc merged 2 commits into
flutter-team-archive:flutter-3.7-candidate.1from
cyanglaz:cp_3.7_platform_view_cliprrect
Jan 19, 2023
Merged

[CP] 3.7 platform view cliprrect#38988
godofredoc merged 2 commits into
flutter-team-archive:flutter-3.7-candidate.1from
cyanglaz:cp_3.7_platform_view_cliprrect

Conversation

@cyanglaz

@cyanglaz cyanglaz commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

This cherry-pick contains 19fe86c and 2a11023

19fe86c is a test only change where 2a11023 depends on.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman and others added 2 commits January 18, 2023 14:45
@jmagman
Update scenario screenshots to iOS 16 (flutter-team-archive#38962)
103fccd 
* Update scenario screenshots to iOS 16

* Rename
[ios_platform_view] more precision when determine if a clip rrect is …
18e8845 
…necessary (flutter-team-archive#38965)

* draft

fix

rename

unittest

* update scenario

* test
@cyanglaz cyanglaz mentioned this pull request Jan 18, 2023
Closed
jmagman
jmagman approved these changes Jan 18, 2023
View reviewed changes

@jmagman jmagman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso mentioned this pull request Jan 19, 2023
Closed
@cyanglaz

cyanglaz commented Jan 19, 2023

Copy link
Copy Markdown
Contributor Author

The CI failure seems to be an infra issue?

ERROR:  Error installing jazzy:
	sqlite3 requires Ruby version >= 2.7, < 3.3.dev. The current ruby version is 2.6.8.205.
Successfully installed liferaft-0.0.6
Successfully installed xcinvoke-0.3.0

@jmagman

jmagman commented Jan 19, 2023

Copy link
Copy Markdown
Contributor

It was flutter/flutter#118805, passed on re-run.

@godofredoc godofredoc merged commit d70f869 into flutter-team-archive:flutter-3.7-candidate.1 Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin
1 more reviewer
@jmagman jmagman jmagman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-ios

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyanglaz @jmagman @godofredoc